Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource Tab Logging - Fix under-app click logs on load #19868

Merged
merged 2 commits into from Jan 9, 2018
Merged

Resource Tab Logging - Fix under-app click logs on load #19868

merged 2 commits into from Jan 9, 2018

Conversation

epeach
Copy link

@epeach epeach commented Jan 9, 2018

Nested the function in addEventListener for under-tab video clicks in an anonymous function so it wouldn't trigger every time the page was reloaded.

davidsbailey
davidsbailey approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you could change the name of the event or study at this time, so that you'll have an easy way to look only at events which happened after this PR.

@epeach epeach merged commit b1f053d into staging Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@epeach @davidsbailey