Teachercon 18-19 Teacher Registration #19874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
force-pushed
the
teachercon1819-registration
branch
3 times, most recently
from
9924e4b
to
afab7fb
Compare
Hamms
force-pushed
the
teachercon1819-registration
branch
from
908d5ba
to
e56ffdf
Compare
Hamms
changed the title
Hamms
force-pushed
the
teachercon1819-registration
branch
from
e56ffdf
to
a095e17
Compare
aoby
approved these changes
Jan 10, 2018
| <p> | ||
| We're excited you're planning to join us this summer! You will | ||
| receive more information about travel approximately six weeks before | ||
| TeacherCon. In the meantime, please <strong>do not</strong> book your flight, and make |
There was a problem hiding this comment.
The first 2 sentences are the same in all cases. Might it make sense to split that out into its own paragraph, supplied once?
There was a problem hiding this comment.
Actually, one says "join the Professional Learning Program" and the other two say "join us this summer" :/
I'mma just leave it as is; if we get lots of changes coming in to the copy I'll probably try and dedup to make those easier.
| 'teacherAcceptSeat', | ||
| 'teacherWaitlistExplain', | ||
| 'teacherDeclineExplain', | ||
| ] |
There was a problem hiding this comment.
This could be Object.keys(Joining.labels), if moved below the labels definition.
| <h4>Section 3: Releases</h4> | ||
| <FormGroup> | ||
| <ControlLabel> | ||
| Please read this <a href="https://docs.google.com/document/d/12NVUcqccNRbVukoGMCserwSpg4vfG0vNlEqTxr6oit0/edit">photo release.</a> |
There was a problem hiding this comment.
Add target="_blank" to open in a new window
| </ControlLabel> | ||
| {this.selectFor("photoRelease", { placeholder: "--" })} | ||
| <ControlLabel> | ||
| Please read this <a href="https://docs.google.com/document/d/15N5N1m-BPCU7obQDf7FLLhEt3IComFGB1u3N6kEQR6k/edit">liability waiver.</a> |
| }; | ||
| } | ||
|
|
||
| //static sessionStorageKey = "Teachercon1819Registration"; |
There was a problem hiding this comment.
oh, thanks! I disabled it for testing and forgot to mark with TODO
| // once they respond yes, but if we do that then the user-visible page count | ||
| // will _grow_ as they progress through the form, which is a much weirder | ||
| // user experience than it shrinking. | ||
| if (!(this.state.data.teacherAcceptSeat && this.state.data.teacherAcceptSeat !== TeacherSeatAcceptanceOptions.accept)) { |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec here
This PR only includes a fullly-implemented teacher version of the form; it will also be updated to support Facilitators and Partners, and a bit of the framework is already in place for that.
TODO:
Follow-up work (in separate PRs):