code for generating discount code report #19899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Jan 10, 2018
| app.school_id, | ||
| ].join(',') | ||
| end | ||
| puts rows |
There was a problem hiding this comment.
Just experimenting: I think you can do this using the CSV module's shortcut interface, but I'm not sure it's actually any better:
def discount_code_reporting
CSV do |csv|
csv << [
# Column names
]
CircuitPlaygroundDiscountApplication.all.each do |app|
csv << [
# columns for row
]
end
end
end| # It will print out a bunch of rows, one per line. You can then copy paste this | ||
| # into google sheets. After pasting, click on the little icon that shows up and | ||
| # select "Split text into columns" | ||
| def discount_code_reporting(filepath) |
There was a problem hiding this comment.
Unused filepath argument?
|
I had actually originally written this doing CSV. However, because it's being run on production-console, getting the file off of the machine and into google sheets becomes a bit of a pain. It felt easier to be able to just copy/paste from the console. |
|
The 'shortcut interface' I used there prints to stdout by default, so should be functionally equivalent to what you wrote. Of course, what you've got works perfectly well and has fewer dependencies. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple script that can be used to generate a report on the current state of our discount codes. Not 100% sure bin/oneoff is the right place for this, but not really sure of a better place either.
After pasting to google sheets, it looks something like this
If this were a higher volume feature, it could make sense to actually build a report view for the web, but I think given that we're expecting <1000 codes to be used, one off is probably ok.