Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle anonymous user #19910

Merged
merged 1 commit into from Jan 11, 2018
Merged

handle anonymous user #19910

merged 1 commit into from Jan 11, 2018

Conversation

Bjvanminnen
Copy link
Contributor

This PR #19753 made it so that if you've previously submitted results for a anonymous survey, we don't show them to you (for privacy reasons).

Those changes led to a regression (HB exception) for signed out users. https://app.honeybadger.io/projects/3240/faults/36100874. This is a fix for that HB error.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for writing the regression test, too!

@Bjvanminnen Bjvanminnen merged commit f7050de into staging Jan 11, 2018
@Bjvanminnen Bjvanminnen deleted the anonHideSurvey branch January 11, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants