Hide map for /yourschool views from outside the US #19933
Conversation
|
@breville I was able to confirm that I get 'us' when I view the page. I wasn't sure how I can test for other countries. Do you have any ideas? |
|
It seems a little strange that if we know they aren't in the US to hide the map, we still default the country to US in the dropdown? |
| {i18n.yourSchoolMapDesc()} | ||
| If you are located in the US, please <a href="#form">fill out the form below</a>. | ||
| If you are outside the US, <a href="/learn/local">add your school here</a>. | ||
| </h3> |
There was a problem hiding this comment.
Does this string still make sense if we've made the determination via IP whether they are in the US or not already?
There was a problem hiding this comment.
I left this as is because the IP-based country determination isn't 100% accurate.
|
Setting the default country is a bit more involved since the dropdown component expects a string with the name of the country vs. the two letter country code. It also requires a bit of new plumbing to get that value from the HAML component to the javascript to the React. We were looking for a minimal change to make the page less US-centric. That said, I'd like to change the default country choice if I can make the time to work on it. |
This undoes the work to hide the map for non-US users in #19933, though leaves the map hiding functionality available in case we need it for something else.
To make /yourschool more friendly to people not in the US we are going to hide the map if the IP is not determined to be from the US.
Before:
After (if not US):
