added the sensor.threshold blocks to levelbuilder and the sandbox #19934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
reviewed
Jan 11, 2018
| "lightSensor.value": null, | ||
| "lightSensor.getAveragedValue": null, | ||
| "lightSensor.setScale": null, | ||
| "lightSensor.threshold": null, |
There was a problem hiding this comment.
Don't change this now, but we should really consolidate this list of blocks into the lib/kits/maker component, maybe even generate it dynamically from the maker dropletConfnig.
islemaster
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sensor.threshold blocks have been added to the sandbox and levelbuilder.
Also, the .start properties are no longer needed and have needed to been taken out of the toolbox for a while now, that change has also been made in this PR as well.
Before:
After:
