Add 'not teaching' option for 2018-19 on teacher app #19957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
approved these changes
Jan 11, 2018
| @@ -181,6 +181,7 @@ def enroll_user | |||
| OTHER_PLEASE_LIST | |||
| ] | |||
|
|
|||
| NOT_TEACHING_NEXT_YEAR = "I'm not teaching next year (please explain):" | |||
| NOT_TEACHING_THIS_YEAR = "I'm not teaching this year (please explain):" | |||
There was a problem hiding this comment.
super nit: reorder so this year comes before next year (and it'll be consistent with the options below)
|
Should "other" and "I'm not teaching" be separate options? Want to make sure this is the right change |
clareconstantine
force-pushed
the
teacher-app-not-teaching
branch
from
fa43e2f
to
5702a78
Compare
|
@mehalshah I checked with Sarah Fairweather and added 'Other (Please Explain):' to both the question about grades currently taught and what you plan to teach next year. Could you give me a quick review with this added commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Added 'Other (Please Explain):' option for the questions about what grades you currently teach and what grades you plan to teach next year. This would be useful for substitutes who don't teach a particular grade, for one example.
On the application:
Detail view:
