Fix bug where unmounting and remounting the school autocomplete would…

[aoby]

… cause it to show blank even when it had a value

This is a bit of a weird case, which was revealed in the teacher application. I'm not sure what VirtualizedSelect is doing under the hood with its caching logic, but it doesn't work in our case. Disabling the cache fixed it.

Repro: when the school autocomplete was unmounted and then remounted, it would always show blank whether or not it had a value. This happened when we switch pages in the teacher application then come back to the school select page. However the first time it mounted (and therefore also after refreshing the page) it would load the options correctly and display the value. I added console.logs to determine that indeed, with the default caching, the underlying VirtualizedSelect was not calling our loadOptions callback when it remounted. With caching disabled now, it does.

I'm not worried about perf since this isn't up for long and shouldn't be making too many duplicate calls, the backend sql query is optimized, and we will be debouncing the API call anyway.

[aoby]

P1 - When I jump back to Page 2, my school has been cleared out

[Hamms]

How difficult would it be to write a test that fully reproduces the original failure case?

[aoby]

I initially tried that and ran into some issues, but I didn't try very hard and I think I may have been making a mistake. I'll give it another shot. I agree that would be better.

[aoby]

@Hamms I can't get it to repro in a test. When I spy getOptions, then unmount and remount the control, getOptions is (correctly) called twice regardless of the value of the cache prop. I can easily repro manually, so I'm probably not recreating the exact conditions. I don't think this is worth much more time, and I like I said I don't see harm in disabling the cache (I'm pretty sure we didn't even know it existed). Let me know if you have any testing ideas or want to take a look at what I have so far.

[Hamms]

Thanks for looking! I agree that it's not super necessary, and this change looks just fine without it.