pass isEnglish to TeacherHomepage #19967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Jan 12, 2018
| @@ -4,7 +4,7 @@ | |||
| - homepage_data[:userid] = current_user.id | |||
| - homepage_data[:valid_grades] = Section.valid_grades | |||
| - homepage_data[:topCourse] = @top_course | |||
| - homepage_data[:isenglish] = @is_english | |||
| - homepage_data[:isEnglish] = @is_english | |||
There was a problem hiding this comment.
it would be good to settle on a casing for these parameters but this one seems consistent with at least one of the above :)
breville
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to conditionally show/hide elements for users who are viewing the teacher homepage in English (similar to /courses). This PR sets up that possibility by passing isEnglish to the TeacherHomepage. Specifically, we want to only show the upcoming special announcement about teacher applications for users in English ; this PR reduces the diff on #19922, which includes that announcement.