address TODOs #19970
Merged
address TODOs #19970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the recommendation from Josh, I'm going through all of the TODOs with my name attached to them and addressing them somehow.
In a lot of cases, that just means deleting them as I have no expectation that anyone will take action on them.
In some cases, I removed the
TODO(brent), but left the text, as it felt like a useful note.The one remaining case is https://github.com/code-dot-org/code-dot-org/blob/staging/apps/src/Sounds.js#L333-L335. I've made a note about it in my brain dump doc, but might just end up addressing it at some point. Edit: PR for that is #19974