Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass missing required prop, and instantiate the control in before() #19971

Merged
merged 1 commit into from Jan 12, 2018
Merged

Pass missing required prop, and instantiate the control in before() #19971

merged 1 commit into from Jan 12, 2018

Conversation

aoby
Copy link
Contributor

@aoby aoby commented Jan 12, 2018

…instead of globally

@aoby aoby requested a review from islemaster January 12, 2018 18:48
islemaster
islemaster approved these changes Jan 12, 2018
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@aoby aoby merged commit 077501a into staging Jan 12, 2018
@aoby aoby deleted the fix-regionalPartnerPanel-test branch January 12, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
code-hygiene testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aoby @islemaster