Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eyes gem 3.5.4 -> 3.14.2 (again) #19973

Merged
merged 1 commit into from Jan 12, 2018
Merged

Upgrade eyes gem 3.5.4 -> 3.14.2 (again) #19973

merged 1 commit into from Jan 12, 2018

Conversation

breville
Copy link
Member

Same as #19879. We manually did the gem upgrade on test and at least some eyes tests worked, so trying again to see if we can diagnose the problem with this PR's approach on test.

@breville
Revert "Merge pull request #19893 from code-dot-org/revert-19879-upda…
98a585a 
…te-eyes-gem-again"

This reverts commit 26175a0, reversing
changes made to 41fde23.

Conflicts:
	Gemfile.lock
@breville breville merged commit 03e17fb into staging Jan 12, 2018
@breville breville deleted the update-eyes-gem-3 branch January 12, 2018 18:57
@breville breville mentioned this pull request Jan 12, 2018
Merged
@breville breville mentioned this pull request Feb 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@breville @islemaster