Update user school info from submitted teacher application #19977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehalshah
approved these changes
Jan 12, 2018
| def update_user_school_info! | ||
| if school_id || user.school_info.try(&:school).nil? | ||
| school_info = get_duplicate_school_info(school_info_attr) || SchoolInfo.create!(school_info_attr) | ||
| user.update!(school_info: school_info) |
There was a problem hiding this comment.
If the user is in an invalid state (and a number of our users are in such a state) then this update will fail for reasons unrelated to school_info I think.
I hate to suggest it but update_column might be justified here
There was a problem hiding this comment.
Good point. Will change.
As an aside, I'd really like for us to fix the user data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @bencodeorg