Tests: Sandbox document.body.innerHTML in ExporterTest #19979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worked out, using an afterEach step in unit-tests.js, that these tests (the ones that use the `runExportedApp` helper) were leaving content in the phantomjs DOM - in particular, that they were leaving a `#divApplab` lying around, which messed with another test I was trying to write. Just saving and restoring document.body.innerHTML so that these tests don't leak DOM elements.
islemaster
force-pushed
the
unit-test-cleanup
branch
from
c71ef97
to
aaea01c
Compare
Bjvanminnen
reviewed
Jan 12, 2018
apps/test/util/testUtils.js
Outdated
| @@ -342,6 +342,12 @@ export function restoreOnWindow(key) { | |||
| delete originalWindowValues[key]; | |||
| } | |||
|
|
|||
| export function sandboxDocumentBody() { | |||
There was a problem hiding this comment.
Worth a comment explaining what it does, why it does it, and what sorts of drawbacks in might have (i.e. the fact that this will blow away attached event handlers).
Bjvanminnen
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on some new tests I discovered that these ExporterTests were leaving a
#divApplabelement in the DOM, which interfered with my new tests. This PR adds a little utility to save and restore the document body around a test, and applies it to this set of tests which will unblock my other PR.I'm gradually working through our test suite finding other places this should be applied, but that's a larger process and will take a while. I'd like to get this fix in on its own for now.