Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter teacher application workshop list to only future workshops #19985

Merged
merged 2 commits into from Jan 13, 2018
Merged

Filter teacher application workshop list to only future workshops #19985

merged 2 commits into from Jan 13, 2018

Conversation

aoby
Copy link
Contributor

@aoby aoby commented Jan 12, 2018

No description provided.

@aoby
Copy link
Contributor Author

aoby commented Jan 12, 2018

Workshop list in application should restrict to only future Workshops

clareconstantine
clareconstantine approved these changes Jan 13, 2018
View reviewed changes
dashboard/test/models/pd/workshop_test.rb

assert_equal future_workshops, Pd::Workshop.future
end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the structure of this test and how easy it is to understand the intended behavior in very little code

@aoby aoby merged commit db93b67 into staging Jan 13, 2018
@aoby aoby deleted the partner-workshops-future branch January 13, 2018 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clareconstantine clareconstantine clareconstantine approved these changes

@mehalshah mehalshah Awaiting requested review from mehalshah

Assignees
No one assigned
Labels
bug-fix professional-learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aoby @clareconstantine