remove unused API #19987
Merged
remove unused API #19987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added logging for this API in this PR #19997. I've seen no HB errors (as expected) leading me to think this is safe to remove. My incentives for removing are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to attempt some cleanup of
section_level_progressand the users_helpers that it uses. In the process, I discovered that I'm pretty sureuser_progress_for_all_scriptsis used nowhere.This API was added by Phil here https://github.com/code-dot-org/code-dot-org/pull/6506/files.
If we think this is too risky, we could initially add some reporting (i.e. throw an HB error or something), and only remove if we actually see it unused.