Jigsaw UX Changes #20000
Jigsaw UX Changes #20000
Conversation
apps/src/jigsaw/blocks.js
Outdated
| blockly.Blocks[name] = { | ||
| helpUrl: '', | ||
| init: function () { | ||
| this.setHSV.apply(this, hsv); | ||
| this.appendDummyInput() | ||
| .appendTitle(new blockly.FieldImage(skin.blank, width, 54)); | ||
| .appendTitle(new blockly.FieldImage(skin.blank, (width-8)/2, 54)) |
There was a problem hiding this comment.
Why the change of width -> (width-8)/2?
Tiny nit: calculate this once above, and store it in a descriptive variable.
There was a problem hiding this comment.
Previously, width was used to supply the total width of the block, but this is only accounting half of it, but this function is only used here, so I can switch to just passing in a smaller value for width if that would be clearer
There was a problem hiding this comment.
Yeah, I think it's a little cleaner to update the places where we call generateBlankBlock above with the new value.
There was a problem hiding this comment.
Or just inline it as always 36 and remove the parameter, now that it's always the same value!
apps/src/jigsaw/blocks.js
Outdated
| .appendTitle(new blockly.FieldImage(skin.blank, width, 54)); | ||
| .appendTitle(new blockly.FieldImage(skin.blank, (width-8)/2, 54)) | ||
| .appendTitle(new blockly.FieldLabel(label, | ||
| {fixedSize: {width: (width-8)/2, height: 64}, fontSize:32})) |
There was a problem hiding this comment.
Tiny nit: fontSize: 32 (space after the colon).
apps/src/jigsaw/blocks.js
Outdated
| .appendTitle(new blockly.FieldImage(skin.blank, (width-8)/2, 54)) | ||
| .appendTitle(new blockly.FieldLabel(label, | ||
| {fixedSize: {width: (width-8)/2, height: 64}, fontSize:32})) | ||
| .setAlign(Blockly.ALIGN_CENTRE); | ||
| this.setPreviousStatement(true); | ||
| if (hasAppend) { |
There was a problem hiding this comment.
Looks like this can go away now 🎉
|
Congrats on your first PR @ryansloan! |
|
Great work, mysterious contributor @ryansloan. |
Responding to frequent user feedback and classroom observations, making a couple small tweaks to Jigsaw puzzles:
removing the pink "loop-like" block from the levels - students don't learn loops until later, and we never actually explain how to use this block in Jigsaw.
Numbering the color-matching blocks These are hard to match to the partially transparent preview on bad screens, and could also present problems for students with color acuity issues or colorblindness