Revert "Revert "log auto and manual DTT starts, green DTTs and red DTTs"" #20051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #20028
With the change in #20043, this PR can be reverted to get the original change that writes DTT metrics to the metrics table.
When initially merged, there was a sequel_connect': undefined methodgsub' for nil:NilClass error, because staging (which currently deliberately doesn’t have metrics db credentials) broke just from the metrics library require because the connection string
devinternal_db_writerwas not present.Currently, only
testwrites metrics. We have credentials being injected successfully ontotestby chef. To fix, I check forCDO.devinternal_db_writerbefore callingsequel_connectto bypass the problem on staging.