Netsim imports colors from shared color scss #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,7 +208,8 @@ config.lodash = { | |||
| config.sass = { | |||
| all: { | |||
| options: { | |||
| outputStyle: (MINIFY ? 'compressed' : 'nested') | |||
| outputStyle: (MINIFY ? 'compressed' : 'nested'), | |||
| includePaths: ['../shared/css/'] | |||
There was a problem hiding this comment.
Here's the new include path. @wjordan is there a new version of this I need to modify as well?
There was a problem hiding this comment.
The new version is currently in the frontend_pipeline branch at lib/frontend/sass.js, I've added a commit that matches this change.
|
Of course, this changes the netsim colors a bit. Now using official colors for packet header columns:
|
|
2015 in history: April 9 – This pull request is opened. |
|
👍 shared code 😍 |
islemaster
added a commit
that referenced
this pull request
Apr 10, 2015
Netsim imports colors from shared color scss
deploy-code-org
added a commit
that referenced
this pull request
Apr 10, 2015
commit cb2861e Merge: 90bf3ad 6d94f33 Author: Brad Buchanan <bradley.c.buchanan@gmail.com> Date: Thu Apr 9 18:04:27 2015 -0700 Merge pull request #2015 from code-dot-org/Update-netsim-colors Netsim imports colors from shared color scss commit 6d94f33 Author: Brad Buchanan <brad@code.org> Date: Thu Apr 9 18:03:48 2015 -0700 Use 'white' and 'black' CSS color constants commit d15c8c3 Author: Brad Buchanan <brad@code.org> Date: Thu Apr 9 17:39:36 2015 -0700 Netsim imports colors from shared color scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a proof-of-concept for using the shared color.scss file from the apps pipeline.