Warn before DTP if DTT is more than 24 hours old #20194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asherkach
reviewed
Jan 24, 2018
bin/dotd
Outdated
| @@ -415,6 +417,15 @@ def print_database_changes(pull_request_number) | |||
| EOS | |||
| end | |||
|
|
|||
| # if the commit is more than 24 hours old, warn | |||
| def print_old_commit(commit_sha) | |||
There was a problem hiding this comment.
nit: My preference would be to name the method the self-descriptive warn_if_old_commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.