Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animations when omitting block count #20210

Merged
merged 2 commits into from Jan 29, 2018
Merged

Fix animations when omitting block count #20210

merged 2 commits into from Jan 29, 2018

Conversation

balderdash
Copy link
Contributor

@balderdash balderdash commented Jan 24, 2018 •
edited

The bubble only turns green after the block counter finishes animating, so we need to skip that step of the animation when there's no block counter.

@balderdash balderdash merged commit 74025b2 into staging Jan 29, 2018
@balderdash balderdash deleted the fix-missing-blocks branch January 31, 2018 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlory joshlory joshlory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balderdash @joshlory