Gamelab respect debuggerDisabled #20245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleybrock
reviewed
Jan 26, 2018
| // NOTE: We will go back to using !config.level.debuggerDisabled soon, | ||
| // but are testing with project levels only for now | ||
| var breakpointsEnabled = config.level.isProjectLevel; | ||
| var breakpointsEnabled = !config.level.debuggerDisabled; |
caleybrock
reviewed
Jan 26, 2018
| // If we were running atMaxSpeed and just reached a breakpoint, the | ||
| // code may not be selected in the editor, so do it now: | ||
| this.selectCurrentCode(); | ||
| if (atMaxSpeed) { |
There was a problem hiding this comment.
I'd like to see the highlighting bug behavior tested, but code looks good.
|
The preferred method of updating the levels would be to run a script on the LB machine since this can cause conflicts, but it looks like there aren't any Game Lab levels being edited on LB right now, so I think this could work. |
|
Looks like circle has a JS interpretor failure, related to this change? |
caleybrock
approved these changes
Jan 29, 2018
|
Trying to re-build on CircleCI - the last run hit this error inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debuggerDisabledlevel flag to determine when the debugger is disabled. All new levels created will have the debugger enabled by default. To simplify the transition, we've disabled the debugger in all of the existing Gamelab curriculum levels and level builders can go back and selectively choose to enable it where it makes sense.addMarkerandremoveMarker