Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only detect git revision changes in test environment #20312

Merged
merged 1 commit into from Jan 30, 2018

Conversation

davidsbailey
Copy link
Member

#20270 fails any ci build if the head git revision changes between the start and end of the build. This is needed in the test environment to make sure we don't accidentally mark the wrong build green. However, it is not appropriate for the staging or levelbuilder branch, where a call to bin/content-push could create a legitimate commit mid-build, and there is no real reason to have it enabled on any other ci machines.

Therefore, restrict the revision checking to only the test environment.

@davidsbailey davidsbailey merged commit a4378f9 into staging Jan 30, 2018
@davidsbailey davidsbailey deleted the restrict-revision-checking branch January 30, 2018 21:44
@davidsbailey davidsbailey restored the restrict-revision-checking branch January 30, 2018 21:44
@davidsbailey davidsbailey deleted the restrict-revision-checking branch January 30, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants