Fix asset thumbnail url in import screens #20330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specified project id
islemaster
approved these changes
Jan 31, 2018
| asset={{filename: 'bar.png', category: 'image', willReplace: false}} | ||
| /> | ||
| ); | ||
| expect(itemWithoutProjectId.find('img').prop('src')).to.contain("/v3/assets/undefined/bar.png"); |
There was a problem hiding this comment.
Nonblocking: Is there a way to assert what the "current project id" is in this test?
There was a problem hiding this comment.
I don't believe so. Since the clientApi.js refers to the project.js to get the project name and this AssetListItem lives independently of a project, I don't believe there is a way to associate this AssetListItem with a project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Axosoft Ticket Describing Bug] (https://codeorg.axosoft.com/viewitem?id=1230&type=features&force_use_number=true)
When importing assets from ProjectA to ProjectB, the import confirmation screen showed an AssetThumbnail which used a url for where the asset would be saved in ProjectB, once the import was complete, resulting in a broken link. I enabled passing in a projectId to AssetThumbnail which, when passed in, specifies the project to which the asset belongs. The import screen now displays a thumbnail of ProjectA's assets when confirming the import of assets and then imports to ProjectB.