Manage students table: reset password for secret words and images #20343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updated this PR to included email account type password resetting: |
Erin007
reviewed
Feb 1, 2018
| editing_password: true, | ||
| }), | ||
| }).done((data) => { | ||
| console.log(data); |
There was a problem hiding this comment.
Do we usually keep these console.logs in or were you just using them to debug?
Erin007
reviewed
Feb 1, 2018
| } else if (this.props.loginType === SectionLoginType.word) { | ||
| this.props.setSecretWords(this.props.id, data.secret_words); | ||
| } | ||
| }).fail((jqXhr, status) => { |
There was a problem hiding this comment.
I also had to look this up - it's the short name for the object we get back when we make an ajax request: http://api.jquery.com/jquery.ajax/
Erin007
reviewed
Feb 1, 2018
| userType: 'student', | ||
| age: 17, | ||
| gender: 'f', | ||
| loginType: 'picture', |
There was a problem hiding this comment.
tiny ? : are picture logins mostly for younger kids?
There was a problem hiding this comment.
younger students definitely use it almost exclusively, but some ms/hs teachers prefer it because its easier for students to manage
Erin007
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManageStudentsTable is part of the teacher dashboard that is behind an experiment
manageStudents, so this change won't be visible to users in production.This allows teachers to reset their students picture and word passwords from the table.
Redux tests included.