Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert applications dashboard ui tests #20347

Merged
merged 3 commits into from Feb 1, 2018
Merged

Revert applications dashboard ui tests #20347

merged 3 commits into from Feb 1, 2018

Conversation

mehalshah
Copy link
Contributor

No description provided.

@mehalshah
Revert "Merge pull request #20342 from code-dot-org/remove_localhost_…
e94805d 
…from_application_dashboard_eyes_tests"

This reverts commit d24396c, reversing
changes made to 9084040.
@mehalshah
Revert "Merge pull request #20333 from code-dot-org/fix_staging_with_…
14c667c 
…pd_step_definitions"

This reverts commit ccd90de, reversing
changes made to cc2417c.
@mehalshah
Revert "Merge pull request #20322 from code-dot-org/teacher_applicati…
f55ad82 
…ons_dashboard_ui_tests_3"

This reverts commit 6456af1, reversing
changes made to f73465e.
balderdash
balderdash approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@balderdash balderdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 that tests are being deleted, but 👍 for making the build green

@mehalshah mehalshah merged commit 24d5c2a into staging Feb 1, 2018
mehalshah added a commit that referenced this pull request Feb 5, 2018
@mehalshah
Revert "Merge pull request #20347 from code-dot-org/revert_applicatio…
7f7d4b7 
…ns_dashboard_ui_tests"

This reverts commit 24d5c2a, reversing
changes made to 9b89016.
@davidsbailey davidsbailey deleted the revert_applications_dashboard_ui_tests branch March 26, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balderdash balderdash balderdash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mehalshah @balderdash