Create basic version of census summarization #20357
Conversation
| @@ -28,4 +28,161 @@ class Census::CensusSummary < ApplicationRecord | |||
| enum teaches_cs: TEACHES | |||
|
|
|||
| validates_presence_of :audit_data | |||
|
|
|||
| def self.submission_teaches_cs(submission, is_high_school) | |||
There was a problem hiding this comment.
how about making this a question mark method?
There was a problem hiding this comment.
Yes, I'll make that change.
| @@ -28,4 +28,161 @@ class Census::CensusSummary < ApplicationRecord | |||
| enum teaches_cs: TEACHES | |||
|
|
|||
| validates_presence_of :audit_data | |||
|
|
|||
| def self.submission_teaches_cs(submission, is_high_school) | |||
| if is_high_school | |||
There was a problem hiding this comment.
is_high_school is an argument to the method, not a method itself. I didn't think that variable names typically ended with a question mark.
There was a problem hiding this comment.
No they don't, and actually can't. If it's a variable, don't worry about it. I thought it was another method call.
| where(schools: {state: state}). | ||
| select(:school_year). | ||
| group(:school_year). | ||
| map(&:school_year) |
There was a problem hiding this comment.
Does pluck(:school_year) work here instead of map? Since we're only selecting that column it probably makes little to no difference so not a big deal.
There was a problem hiding this comment.
Both work and generate the exact same SQL.
| latest_survey_year, | ||
| latest_ap_data_year, | ||
| latest_ib_data_year, | ||
| latest_state_data_years.map {|_, v| v}.max |
There was a problem hiding this comment.
What does this do? AFAIK map for an array will only provide a single parameter to the block. Are you missing a key, or is this meant to be something else?
irb(main):001:0> [1,2].map{|_,v| v}
=> [nil, nil]There was a problem hiding this comment.
latest_state_data_years is a hash, not any array. The keys are the state code and the value is the latest year that has data for that state. This is taking the latest year across all states that have data. This would be clearer if I rename latest_state_data_years to latest_data_year_by_state and then do latest_data_year_by_state.values.max
There was a problem hiding this comment.
OIC. That makes sense. I misread that anyway and thought the map was outside the array. Maybe add a small comment (or rename as you suggested).
There was a problem hiding this comment.
I cleaned this up a bit. Is it clearer now?
| yes_count = 0 | ||
| no_count = 0 | ||
|
|
||
| # If the schools doesn't have stats then treat it as not high school. |
Creates an initial version of census summarization logic which counts any inconsistent data as a MAYBE. This logic will change to something more complex soon but we want to populate the summary table to make it easier to build out visualizations. For now I am adding a one-off script to run this code, to be moved to a cron job once we have a more finalized version of the logic in place.
I also needed to add in some reverse relationships in the models to be able to get from a School to the various census data. From my testing I do not believe that this will impact anything since those relations aren't loaded by default.