More copy + TeacherCon registration form updates #20376
Conversation
tanyaparker
changed the title
| ); | ||
| } else if (data['course'] === 'CS Discoveries') { | ||
| requiredFields.push( | ||
| 'howManyHours', | ||
| 'howManyTerms' | ||
| 'howManyTerms', | ||
| 'gradingSystem' |
There was a problem hiding this comment.
If this is required in both (all) cases, it could just be a static required field in the ruby class.
There was a problem hiding this comment.
After chatting w @mehalshah, we're going to leave this where it is in case course is ever something else.
| </FormGroup> | ||
| } | ||
|
|
||
| {this.props.course === "CS Discoveries" && | ||
| <FormGroup> | ||
| {this.radioButtonsFor("howManyHours")} | ||
| {this.radioButtonsFor("howManyTerms")} | ||
| {this.radioButtonsWithAdditionalTextFieldsFor("gradingSystem", { | ||
| [TextFields.otherPleaseList]: "grading_system_other" | ||
| })} |
There was a problem hiding this comment.
Not a big deal but this could be reworked slightly to reduce repeated code, making the <FormGroup> and these gradingSystem radio buttons common, then branching for CSD/CSP for the course-specific fields.
|
Actually, CSP was missing more questions. Almost matched to spec now. It looks like there still should be a question "How many course hours per week will your school offer CS Principles?" but idk how to add a new question so I'll create a new card for that. |
tanyaparker
changed the base branch from
teachercon_registration_form_updates
to
staging
|
@mehalshah PTAL at my addition: 3efaca8 |
…r consistency (the key format is transformed back and forth so it has no actual effect)
If approved to merge, I'll merge into staging after #20363.
gradingSystemshould be a question for both CSD and CSP