Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "allow parens in applab image names" #20383

Merged
merged 4 commits into from Feb 7, 2018

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Feb 2, 2018

Reverts #20382, restoring #20368 , with fixes for images starting with http(s)://

changes made after reverting:

  1. only escape relative filenames (those uploaded by the user)
  2. change existing integration test to cover relative urls
  3. add integration test to cover fully qualified url (starting with http://)
  4. add integration test to cover absolute url (starting with /)

manual tested (relative path, absolute path, fully qualified url) in each of the following situations:

  • design mode: screen, button, image
  • code mode image(id, url):
  • code mode setProperty(id, 'image', url):
    • screen
    • code-created image
    • code-created button
    • design-created image
    • design-created button

@davidsbailey davidsbailey force-pushed the revert-20382-revert-20368-applab-image-parens branch from dd2ab57 to 37cdd36 Compare February 6, 2018 21:22
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yay additional tests.

@davidsbailey davidsbailey merged commit b93e613 into staging Feb 7, 2018
@davidsbailey davidsbailey deleted the revert-20382-revert-20368-applab-image-parens branch February 7, 2018 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants