Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inactive adhoc cron job to check for terminated instance #20425

Merged

Conversation

sureshc
Copy link
Contributor

@sureshc sureshc commented Feb 5, 2018

Check if Instance is nil because sometimes an engineer manually Terminates the Instance provisioned for an adhoc stack instead of running rake adhoc:stop to delete the entire adhoc stack.

https://app.honeybadger.io/projects/45435/faults/36538130

…nates the Instance provisioned for an adhoc stack instead of running `rake adhoc:stop` to delete the entire adhoc stack
Copy link
Contributor

@wjordan wjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming you've manually tested/verified this fix, looks good to me 👍

@sureshc sureshc merged commit a5cf6eb into staging Feb 5, 2018
@sureshc sureshc deleted the fix-inactive-adhoc-cron-job-for-terminated-instances branch February 5, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants