pull all of maze.js's animation logic out into dedicated animationsController #20467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
force-pushed
the
maze-make-private
branch
from
eead1e1
to
ce2f94a
Compare
Hamms
force-pushed
the
maze-extract-animations-redo
branch
from
59d917b
to
f430e20
Compare
Hamms
force-pushed
the
maze-make-private
branch
from
ce2f94a
to
8b0e0d9
Compare
Hamms
force-pushed
the
maze-extract-animations-redo
branch
2 times, most recently
from
ec3d2cc
to
50dc78f
Compare
Hamms
changed the title
joshlory
approved these changes
Feb 10, 2018
|
|
||
| module.exports = class AnimationsController { | ||
| constructor(maze, svg) { | ||
| this.maze = maze; |
There was a problem hiding this comment.
Long term is the plan to only pass in the options we need, vs. the entire Maze reference?
…ce it doesn't actually have anything to do with animations
Hamms
force-pushed
the
maze-extract-animations-redo
branch
from
77b70cc
to
4f5be83
Compare
balderdash
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.