remove clearSelection(), rename selectAndHighlightCode() #20471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearDropletAceHighlighting()
cleared the ACE editor selection in addition to clearing highlights. Presumably, this was originally done because it was the function to "clear" what was done inselectAndHighlightCode()
, which used to both select AND highlight the code. Now, that function only does highlighting (and no selection). Renamed that function tohighlightCode()
to be more clear and removed the ACE editorclearSelection()
call fromclearDropletAceHighlighting()
Since we recently starting calling this function once per
executeInterpreter()
, it was preventing students from being able to select code while runningOther places where
clearDropletAceHighlighting()
is called, that will no longer clear ACE selection:In both places, it feels like an improvement to avoid interfering with the ACE editor selection.