Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maker landing page React component and story #20507

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Feb 8, 2018

We want to have a landing page for Maker Toolkit to give students working on unit 6 easy access to all of the information they need, spec.

This PR builds a MakerLanding component that has a customizable TopCourse component and cards for creating a new project, viewing your project list, and visiting the Maker setup page.

Screenshot of the Story, not currently used anywhere on the site:
screen shot 2018-02-08 at 2 54 42 pm

Notes: The image for viewing the setup page is a placeholder until Mark is finished with the asset. I plan to pass in topCourse information rather than hard code because different students will be working on different lessons, and it should be customize to where they are in the course.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfection

return (
<div>
<h1 style={styles.title}>
Code.org Maker App
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we localize this string?

@Erin007 Erin007 merged commit dc2a490 into staging Feb 9, 2018
@Erin007 Erin007 deleted the maker-landing-page branch February 9, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants