Organize turtle avatars as skin settings #20513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
reviewed
Feb 9, 2018
apps/src/turtle/skins.js
Outdated
| width: 73, | ||
| height: 100, | ||
| numHeadings: 36, | ||
| image: new Image(), |
There was a problem hiding this comment.
is there a specific reason this declaration was moved here rather than staying in turtle? All the others make sense, but I don't love the idea of creating a new Image in a config file
Hamms
reviewed
Feb 9, 2018
apps/src/turtle/turtle.js
Outdated
| @@ -727,18 +711,9 @@ Artist.prototype.drawImages = function () { | |||
| */ | |||
| Artist.prototype.loadTurtle = function (initializing = true) { | |||
| const onloadCallback = initializing ? this.display : this.drawTurtle; | |||
| this.avatarImage.onload = _.bind(onloadCallback, this); | |||
| this.avatar.image.onload = _.bind(onloadCallback, this); | |||
There was a problem hiding this comment.
you'll need to declare the new Image() somewhere. I vote here.
joshlory
force-pushed
the
organize-turtle-avatars
branch
from
b81607d
to
b4e3091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.