Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook Button hierarchy #20514

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Storybook Button hierarchy #20514

merged 1 commit into from
Feb 9, 2018

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Feb 9, 2018

As an initial step in organizing our Storybook such that it will be more useful and less cluttered, we're going to implement a hierarchy that will allow us to group similar components. This will allow us to see redundancy in our components, potentially consolidate and deprecate, and more easily find pre-existing components when designing new features.

By prepending a category, in this case "Button/" to storiesOf, Storybook (now that we are using version 3.2) will automatically group and collapse components in the same category. As a start, I made a Buttons category, sub-divided based on whether the button is used in games or more broadly on the site.

button-hierarchy

Note: This does not change the use of any components, their Stories or where they are in our codebase; it just starts to declutter the list on the left panel of Storybook.

Next steps:

  • Investigate if we can delete some of these buttons, particularly LegacyButton and DialogButtons.
  • Investigate whether buttons that do not have Stories (CollapserButton, ScrollButtons, ArrowButtons, StepButton, and LargeChevronLink, for example - this list is not exhaustive) need Stories, warrant their own component or could be swapped out for a standardized button, and/or should be grouped in this Button hierarchy.
  • Consolidate other similar components, such as Dialogs, into hierarchical categories.

Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Thanks for getting this process started!

Copy link
Contributor

@caleybrock caleybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants