Convert 404.haml to markdown #20518
Merged
Convert 404.haml to markdown #20518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
--- looks like I typed this comment late last night, but I never submitted it. sorry about that! --- can you post a screenshot? You took out some custom styles so I want to see if this looks close enough to the same also, I don't think this is bad to do, but I wouldn't spend too much time converting a bunch of these until we are all bought in that markdown is the way of the future. |
|
Before:
After:
If we find the new text is too small we should update the default text size, instead of overriding it on every page 😛. |
caleybrock
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.