Census auto update new map #20575
Merged
Census auto update new map #20575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Feb 13, 2018
| @@ -46,6 +46,7 @@ def load_configuration | |||
| 'build_apps' => false, | |||
| 'build_dashboard' => true, | |||
| 'build_pegasus' => true, | |||
| 'census_map_table_id' => rack_env == :production ? '1AUZYRjLMI5NiQsDeDBGFsOIFpL_rLGsnxNpSyR13' : nil, | |||
There was a problem hiding this comment.
Is there any downside to this being in the repo?
There was a problem hiding this comment.
I don't think so. You can see the value if you view source on the page.
breville
reviewed
Feb 13, 2018
| # After setting up authentication, provide the following CDO.* attributes: | ||
| # CDO.hoc_map_account: (JSON of a credential which can edit the FusionTables table) | ||
| # CDO.census_map_table_id: (the id of the fusion table) | ||
|
|
There was a problem hiding this comment.
We can still set these via locals.yml?
There was a problem hiding this comment.
Yes. That is how I'm testing.
breville
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to replace the current map on /yourschool with one showing every school in the DB and if we believe they each teach CS. I have created a new fusion table to use for this so that we can keep the old map up and running while the new UI is under development. The new
update_census_mapscript will populate the fusion table nightly based on thecensus_summariestable. This script is heavily modeled afterupdate_pledge_map.Per guidance from @wjordan I did not put the table id in Chef and instead put it in
deployment.rbTo make it harder for somebody to overwrite the production table from another environment, I only set the value in production.