Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break applab eyes tests into multiple files #20581

Merged
merged 2 commits into from Feb 13, 2018
Merged

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Feb 13, 2018

Similar to how UI tests for initialPageViews are divided into 3 files, this PR divides applab eyes tests into multiple files. This is done so that these tests can run in parallel to reduce overall run time. Similarly, if applab tests need to be re-run, re-running a sub-set rather than all of them will be quicker.

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Erin! One minor request below. I was going to ask you to name these files more descriptively, but it sure seems hard to come up with names that would mean anything for most of these groups of scenarios.

@@ -1,7 +1,7 @@
@eyes
@dashboard_db_access
@as_student
Feature: App Lab Eyes
Feature: App Lab Eyes - Part 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we call this file eyes1 so that we can find it by grepping for applab_eyes1 (rather than applab_eyes which is more ambiguous)?

@Erin007 Erin007 merged commit 1a45854 into staging Feb 13, 2018
@Erin007 Erin007 deleted the applab-eyes-multi-files branch February 13, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants