Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to droplet code-dot-org commit 04d9b55 #20620

Merged
merged 2 commits into from Feb 14, 2018
Merged

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Feb 14, 2018

  • Updates droplet with changes in droplet-editor/droplet@04d9b55
    • We now support scrolling the editor while dragging. This partially worked in text mode with Ace, but did not work at all for block mode. Patched up Ace to allow the scroll events to occur when dragging above/below ace and over the gutter. Implemented block-mode scrolling when the dragging block is close to any of the four edges of the editor.
    • Fixed block dropping so you can drop when you are over the gutter. It used to work this way before the big SVG merge. It is much more forgiving this way.

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few questions inline on the droplet commit you linked to.

@davidsbailey
Copy link
Member

This is an awesome feature, by the way. I am excited to try it out!

@cpirich cpirich merged commit 9bdecef into staging Feb 14, 2018
@cpirich cpirich deleted the droplet_scrolling branch February 14, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants