A/B test: remove "optional" text on signup page #20622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewjordan
commented
Feb 14, 2018
| @@ -230,6 +260,8 @@ window.SignupManager = function (options) { | |||
| $("#user_terms_of_service_version").prop('checked', false); | |||
|
|
|||
| updateAutocompleteSchoolFields(schoolData); | |||
|
|
|||
| sendSchoolInfoSplitTestEvent('signup-loaded'); | |||
There was a problem hiding this comment.
No isTeacherSelected needed here because this is within the showTeacher function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 50% of users signing up as a teacher, change "School Information (optional)" to "School Information" without actually changing the fact that it is optional to supply it.
The goal here is to test two things:
As such we're collecting the country and the NCES ID selected (which will be null if no school has been looked up in the list).
A/B test summary:
study:school-info-optionalstudy_group:controloroptional-removed, 50/50 weightingevent:signup-loaded,signup-submitted,signup-success,signup-errordata_json: usual fields, pluscountryandncesUse
uuidto identify users across events, since user IDs haven't been created yet on the signup page.