Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track when a user solves a puzzle with fewer than the ideal # of blocks #20638

Merged
merged 10 commits into from Feb 28, 2018
Merged

Track when a user solves a puzzle with fewer than the ideal # of blocks #20638

merged 10 commits into from Feb 28, 2018

Conversation

joshlory
Copy link
Contributor

Request from @kiki-lee.

@joshlory joshlory requested a review from Hamms February 14, 2018 23:28
Hamms
Hamms reviewed Feb 15, 2018
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand a bit more on the desire for this? Given the current complexity of our test results system I'm extremely hesitant to introduce an entirely new success case, particularly when we already have an (admittedly poorly-named) TOO_MANY_BLOCKS_FAIL case for when they pass the level while exceeding the recommended block limit

@joshlory
Copy link
Contributor Author

This is the opposite of TOO_MANY_BLOCKS_FAIL. Block target of 9, student solves it in only 7 blocks... Kiki wants to track when kids are finding clever solutions to a problem or using a repeat loop before it's introduced in the curriculum.

@joshlory joshlory mentioned this pull request Feb 19, 2018
Merged
@joshlory
Copy link
Contributor Author

Ok, I think this is ready for review!

@joshlory
Copy link
Contributor Author

PTAL.

Hamms
Hamms approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshlory joshlory merged commit 941b024 into staging Feb 28, 2018
@joshlory joshlory deleted the better-than-perfect branch February 28, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshlory @Hamms