Remove learn/legacy and add redirect to /learn #20643
Conversation
caleybrock
force-pushed
the
remove-learn-legacy
branch
from
bd6f474
to
d247763
Compare
| @@ -0,0 +1 @@ | |||
| /learn | |||
There was a problem hiding this comment.
Can this be a .moved file since it's a permanent move?
There was a problem hiding this comment.
I thought .moved was for pages where we take the same page and move it to another place, where as in this case we are just deprecating the page.
There was a problem hiding this comment.
From will:
pretty sure the .moved/.redirect stuff is a legacy/undocumented feature of pegasus (https://github.com/code-dot-org/pegasus/commit/088d1f543c0289c5e1d080cb9ee1b18e02f5eee0), so i don't have any extra rule of thumb to give there. Apparently .moved and .redirect do the same thing, and .redirect was added as an alias for .moved per hadi? (https://github.com/code-dot-org/pegasus/commit/4e4599abbf2b626bfd31743406f3dbf34030f20c)
.found does a 302 temporary redirect, .moved and .redirect to 301 permanent redirects.
|
|
||
| = view 'mobilecheck.js' | ||
|
|
||
| = view :learn_teacher_banner |
There was a problem hiding this comment.
Looks like this is the only file exclusively used by this file, so good job catching that it's okay for deletion.
On average about 15 people a day are viewing this page so Tanya and I agree it can be removed.