Some bug bash changes to the FiT registration form #20652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
reviewed
Feb 15, 2018
| Releases, | ||
| Confirmation | ||
| ]; | ||
| if (this.state.data.ableToAttend === 'Yes') { |
There was a problem hiding this comment.
this seems redundant with the early shouldShowSubmit; is there a specific reason for this?
There was a problem hiding this comment.
So the bottom looks like this
There was a problem hiding this comment.
Ah, just to avoid showing the page changer?
If that's a general concern, we might want to consider updating the base FormController to be smarter about showing the page changer when shouldShowSubmit indicates an early submit, but that's an issue for a future PR
Hamms
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.