log whenever the source or an animation for a project is restored #20660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One failure mode for data loss we've observed is that new versions of projects get overwritten by older versions. One possibility is that the older versions are appearing due by the "restore previous version" endpoint. Because we don't expect restore requests to happen very often, let's start logging all restore requests so that we can determine if restore requests are part of the problem when debugging problem projects.
Note that this logging will log one restore request on the sources bucket for any restored project, and will additionally log one restore request on the animations bucket for each animation in the project, if it is a Game Lab project and has any custom animations.