Allow workshop admins to edit Fit workshop assignment. #20663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
force-pushed
the
fit-weekend-assignment
branch
from
ba2c843
to
91241f5
Compare
assignment control more generic and clean up that code. Remove unused parameters, and add tests.
aoby
force-pushed
the
fit-weekend-assignment
branch
from
91241f5
to
3164857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make workshop assignment control more generic and clean up that code. Remove unused
parameters, and add tests.
Now, workshop assignments (summer and fit where applicable) only appear at the top of the detail view. In read mode they are displayed with a link or "Unassigned". In edit mode, they display selects with the choices. Both teacher and facilitator applications have summer assignments. Only facilitator applications have FIT assignments, and only workshop admins can edit these.
Unassigned:
Edit:
Assigning:
Assigned (saved):
Facilitators
Admins double-edit:
Partners can only edit the summer workshop:
