Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add trace to rake seed on test #20689

Merged
merged 1 commit into from
Feb 27, 2018
Merged

add trace to rake seed on test #20689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rake/build.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ namespace :build do
else
ChatClient.log 'Seeding <b>dashboard</b>...'
ChatClient.log 'consider setting "skip_seed_all" in locals.yml if this is taking too long' if rack_env?(:development)
RakeUtils.rake 'seed:all'
RakeUtils.rake 'seed:all', (rack_env?(:test) ? '--trace' : nil)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I include ENV['CI'] as well? My understanding is that would detect the CircleCI environments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RACK_ENV is test in our CircleCI builds as well:

code-dot-org/.circleci/config.yml

Lines 14 to 16 in cf86dfa

environment:
RAILS_ENV: test
RACK_ENV: test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

end

# Commit dsls.en.yml changes on staging
Expand Down Expand Up @@ -125,7 +125,7 @@ namespace :build do
if CDO.daemon
ChatClient.log 'Updating <b>pegasus</b> database...'
begin
RakeUtils.rake 'pegasus:setup_db'
RakeUtils.rake 'pegasus:setup_db', (rack_env?(:test) ? '--trace' : nil)
rescue => e
ChatClient.log "/quote #{e.message}\n#{CDO.backtrace e}", message_format: 'text'
raise e
Expand Down