Just being honest #20713
Merged
Just being honest #20713
Commits on Feb 17, 2018
-
Replace this editorless-hack...
...with setting an editor enum or (even better) inject an appropriate editor-adaptor.
-
This getValue() call is a workaround...
...for a Droplet bug, See droplet-editor/droplet#137 Calling getValue() updates the cached ace editor value, which can be out-of-date in droplet and cause an incorrect early-out. Could remove this line once that bug is fixed and Droplet is updated.
-
-
-
This sequencing feels backwards...
...Eventually, we ought to preview and get dimensions from the local filesystem, async with the upload itself, but that will mean refactoring away from the jQuery uploader.
-
-
-
-
This whole file should go away...
...when we have a shared Javascript User object that can be available on page load.
-
-
...more likely to ensure it's unique and fits within 48 characters. Maybe grab this MIT-licensed implementation via node? https://github.com/blueimp/JavaScript-MD5
-
Do we benefit from inheritance here? Would it be cleaner to make this not-an-entity that manipulates a stock NetSimClientNode? Will another developer find it easy to understand how this class works?
-
Modify and return the template node...
...instead of making two in this method.
-
...and ticking the routers up to netsim.js (or elsewhere)
-
...so we can be notified when writes succeed instead of making a 50ms guess, and make this a properly async method.
-
This is to expose methods we need...
...in the global namespace for testing purpose. Would be nice to eliminate this eventually.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.