Fix summer workshop enrollment emails to display actual workshop subj… #20780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect instead of always CSP
aoby
commented
Feb 21, 2018
| @@ -33,7 +33,8 @@ | |||
| %ul | |||
| %li | |||
| It helps us understand who the population of teachers involved in our | |||
| Computer Science Principles (CSP) PD program are. | |||
| = @workshop.course | |||
There was a problem hiding this comment.
@tanyaparker is this ok to use the course name, e.g. "CS Principles", or do we want to preserve the spelled out "Computer Science Principles (CSP)" style?
There was a problem hiding this comment.
Ok to use CS Principles so we can generalize and use the same method everywhere.
clareconstantine
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ect instead of always CSP
Note (semi-related), mail previews are currently broken. Fix here