Workaround ActiveSupport bug missing require #20801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: rails/rails#28918 Fixed in ActiveSupport 5.1.1.
wjordan
requested review from
drewsamnick
and removed request for
drewsamnick
|
@drewsamnick you can merge staging into your local branch now to unblock on this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around an ActiveSupport bug missing a
requirestatement on certain platforms, due to a platform-dependent require inactive_support/core_extsometimes triggering a load-order-dependent missing-require error (rails/rails#28918).The bug is fixed in ActiveSupport 5.1.1; until we upgrade, this workaround should avoid triggering this bug in the
update_certsscript.