Program manager permission #20803
Merged
Program manager permission #20803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareconstantine
requested review from
mehalshah
and removed request for
mehalshah
clareconstantine
force-pushed
the
program-manager-permission
branch
from
e144c2a
to
80e6424
Compare
clareconstantine
force-pushed
the
program-manager-permission
branch
2 times, most recently
from
0eb67c2
to
c22d638
Compare
added 14 commits
February 27, 2018 11:38
clareconstantine
force-pushed
the
program-manager-permission
branch
from
03bd59d
to
9542b5d
Compare
mehalshah
reviewed
Feb 28, 2018
| @@ -74,7 +74,7 @@ def assign_program_manager | |||
|
|
|||
| # GET /regional_partners/:id/remove_program_manager | |||
| def remove_program_manager | |||
| @regional_partner.program_managers.delete(params[:program_manager_id]) | |||
| @regional_partner.program_managers.destroy(params[:program_manager_id]) | |||
There was a problem hiding this comment.
Ick! Why were we deleting instead of destroying here any way?
| @@ -17,4 +17,14 @@ class RegionalPartnerProgramManager < ActiveRecord::Base | |||
| belongs_to :regional_partner | |||
|
|
|||
| has_many :pd_workshops_organized, class_name: 'Pd::Workshop', through: :program_manager | |||
|
|
|||
| after_create do | |||
| program_manager.permission = 'program_manager' | |||
There was a problem hiding this comment.
Use the UserPremission::PROGRAM_MANAGER constant
|
|
||
| after_destroy do | ||
| if program_manager.regional_partners.empty? | ||
| program_manager.delete_permission 'program_manager' |
mehalshah
approved these changes
Feb 28, 2018
| @@ -16,6 +16,7 @@ describe("Permission class", () => { | |||
| expect(permission.isWorkshopAdmin).to.be.true; | |||
There was a problem hiding this comment.
You should augment workshop_indexTest.js as well
added 2 commits
February 27, 2018 17:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
program_managerpermission that has the same abilities asworkshop_organizerThis PR creates the permission, and when a user becomes a program manager, they receive the permission. When their last
RegionalPartnerProgramManageris destroyed, the permission is removed.This PR also updates the backend and one pegasus helper to check for
program_managereverywhere we check forworkshop_organizer.